feat: chain manager with longest-chain fork resolution and state replay#33
Closed
arunabha003 wants to merge 27 commits intoStabilityNexus:mainfrom
Closed
feat: chain manager with longest-chain fork resolution and state replay#33arunabha003 wants to merge 27 commits intoStabilityNexus:mainfrom
arunabha003 wants to merge 27 commits intoStabilityNexus:mainfrom
Conversation
Contributor
|
Caution Review failedFailed to post review comments WalkthroughIntroduces a complete blockchain implementation scaffold with core primitives (blocks, transactions, state, consensus), a fee-based mempool with nonce ordering, dynamic difficulty adjustment, canonical serialization, and comprehensive test coverage alongside build tooling. Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Client
participant ChainManager as ChainManager
participant Block as Block
participant State as State
participant Mempool as Mempool
Client->>ChainManager: add_block(block)
ChainManager->>ChainManager: Check duplicate & known parent
ChainManager->>Block: Validate merkle root & coinbase
alt Block valid
ChainManager->>State: Replay state along candidate path
State-->>ChainManager: Updated state
ChainManager->>ChainManager: Validate consensus (PoW, difficulty)
ChainManager->>ChainManager: Decision: extend/reorg/fork
ChainManager->>ChainManager: Update canonical chain & tip
ChainManager->>Mempool: Remove confirmed transactions
ChainManager-->>Client: Return tx_id
else Block invalid
ChainManager-->>Client: Raise ChainValidationError
end
Estimated Code Review Effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly Related PRs
Suggested Labels
Suggested Reviewers
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Feb 23, 2026
Author
|
Superseded by #34. Closing this PR to keep review history in one place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed Issues:
Part of #8
Depends on #31
Summary
Validation
Checklist
AI Usage Disclosure
Check one of the checkboxes below:
I have used the following AI models and tools: TODO
We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact.
Summary by CodeRabbit
Release Notes
New Features
Chores
Tests